cri/config: fix range iterator issue in ValidatePluginConfig

gaurav1086 · gaurav1086 · commit 071a185506bd · 2020-12-04T17:37:09.000-05:00
Go uses the same address variable while iterating in a range,
so use a copy when using its address.

Signed-off-by: Gaurav Singh &lt;gaurav1086@gmail.com&gt;
diff --git a/pkg/cri/config/config.go b/pkg/cri/config/config.go
@@ -352,6 +352,7 @@ func ValidatePluginConfig(ctx context.Context, c *PluginConfig) error {
 			c.Registry.Configs = make(map[string]RegistryConfig)
 		}
 		for endpoint, auth := range c.Registry.Auths {
+			auth := auth
 			config := c.Registry.Configs[endpoint]
 			config.Auth = &auth
 			c.Registry.Configs[endpoint] = config

Original file line number	Diff line number	Diff line change
`@@ -352,6 +352,7 @@ func ValidatePluginConfig(ctx context.Context, c *PluginConfig) error {`
`352`	`352`	`c.Registry.Configs = make(map[string]RegistryConfig)`
`353`	`353`	`}`
`354`	`354`	`for endpoint, auth := range c.Registry.Auths {`
	`355`	`+ auth := auth`
`355`	`356`	`config := c.Registry.Configs[endpoint]`
`356`	`357`	`config.Auth = &auth`
`357`	`358`	`c.Registry.Configs[endpoint] = config`