task service: return known error type

cpuguy83 · cpuguy83 · commit 02e77bcdc1e4 · 2021-10-01T17:45:51.000Z
Found this error in a docker daemon log classified as an "uknown" error.
Since we know what this is return the correct error type so it can be
handled.

Signed-off-by: Brian Goff &lt;cpuguy83@gmail.com&gt;
diff --git a/services/tasks/local.go b/services/tasks/local.go
@@ -210,7 +210,7 @@ func (l *local) Create(ctx context.Context, r *api.CreateTaskRequest, _ ...grpc.
 		return nil, errdefs.ToGRPC(err)
 	}
 	if err == nil {
-		return nil, errdefs.ToGRPC(fmt.Errorf("task %s already exists", r.ContainerID))
+		return nil, errdefs.ToGRPC(fmt.Errorf("task %s: %w", r.ContainerID, errdefs.ErrAlreadyExists))
 	}
 	c, err := rtime.Create(ctx, r.ContainerID, opts)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ func (l local) Create(ctx context.Context, r api.CreateTaskRequest, _ ...grpc.`
`210`	`210`	`return nil, errdefs.ToGRPC(err)`
`211`	`211`	`}`
`212`	`212`	`if err == nil {`
`213`		`- return nil, errdefs.ToGRPC(fmt.Errorf("task %s already exists", r.ContainerID))`
	`213`	`+ return nil, errdefs.ToGRPC(fmt.Errorf("task %s: %w", r.ContainerID, errdefs.ErrAlreadyExists))`
`214`	`214`	`}`
`215`	`215`	`c, err := rtime.Create(ctx, r.ContainerID, opts)`
`216`	`216`	`if err != nil {`