You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that this does NOT fully fix#79 because there is one more issue with master.getCurrent. For some reason, TIOCGETA ioctl returns ENOTTY. So, while it no longer crashes, it doesn't work properly.
Note that this does NOT fully fix #79 because there is one more issue with master.getCurrent. For some reason, TIOCGETA ioctl returns ENOTTY. So, while it no longer crashes, it doesn't work properly.
TIOCGETA should be called on the TTY slave not the PTY master. master.getCurrent always uses the PTY master to get the current termios
So, do you want to say that this library is fully broken? master doesn't have a pointer to slave fd, so almost all its methods that use tcget/tcset are not functional under macOS (and, possibly, FreeBSD)?
So, do you want to say that this library is fully broken? master doesn't have a pointer to slave fd, so almost all its methods that use tcget/tcset are not functional under macOS (and, possibly, FreeBSD)?
Of course not 😄 this library is actually pretty awesome and I use it every day!
It's just that I tested it with the slave fd and the tests passed just fine. So maybe it's a Darwin thing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #79
Note that this does NOT fully fix #79 because there is one more issue with
master.getCurrent. For some reason,TIOCGETAioctl returnsENOTTY. So, while it no longer crashes, it doesn't work properly.