Skip to content

Distinguish not exist error returned by Path.#30

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-deleted-error
Oct 5, 2017
Merged

Distinguish not exist error returned by Path.#30
crosbymichael merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-deleted-error

Conversation

@Random-Liu
Copy link
Member

@crosbymichael path may also return not exist error, e.g. /proc/PID/cgroup may not exist.

We should also return ErrCgroupDeleted in that case.

Signed-off-by: Lantao Liu [email protected]

@codecov-io
Copy link

codecov-io commented Oct 5, 2017

Codecov Report

Merging #30 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   13.74%   13.74%   -0.01%     
==========================================
  Files          22       22              
  Lines        4110     4112       +2     
==========================================
  Hits          565      565              
- Misses       3439     3441       +2     
  Partials      106      106
Impacted Files Coverage Δ
cgroup.go 47.73% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5933ab4...1f936e8. Read the comment docs.

@Random-Liu Random-Liu changed the title Distinguish not exist error from Path. Distinguish not exist error returned by Path. Oct 5, 2017
@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 9c238e6 into containerd:master Oct 5, 2017
@Random-Liu Random-Liu deleted the fix-deleted-error branch October 5, 2017 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants