Cgroup2: Testify all tests#285
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Apr 24, 2023
Merged
Conversation
samuelkarp
approved these changes
Apr 12, 2023
Use require/assert for all the cgroup2 tests. These tests were in a
weird spot where some of them used a mix of testify.assert, and some
used `testify.require` in place of `if err != nil { t.Fatal() }`. This
just moves everything over to `require.NoError` and friends.
Signed-off-by: Danny Canter <[email protected]>
samuelkarp
approved these changes
Apr 13, 2023
austinvazquez
approved these changes
Apr 14, 2023
AkihiroSuda
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use require/assert for all the cgroup2 tests. These tests were in a weird spot where some of them used a mix of testify.assert, and some used
testify.requirein place ofif err != nil { t.Fatal() }. This just moves everything over torequire.NoErrorand friends.