Use sync (bufferpool) to reduce allocation in controllers. #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReadUint is modified to take a byteBuffer and the file contents are copied into it. The buf sync pool is created at the controller level so that it controller determines if it needs one. Ran a benchmark on pids test. Earlier: goos: linux goarch: amd64 pkg: github.com/containerd/cgroups/v3/cgroup1 cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz BenchmarkPids-8 59758 19905 ns/op 2064 B/op 15 allocs/op PASS ok github.com/containerd/cgroups/v3/cgroup1 1.405s With this change: goos: linux goarch: amd64 pkg: github.com/containerd/cgroups/v3/cgroup1 cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz BenchmarkPids-8 57368 21665 ns/op 1345 B/op 13 allocs/op PASS ok github.com/containerd/cgroups/v3/cgroup1 1.467s Inspired from: containerd#275 Signed-off-by: Manu Gupta <[email protected]>
Contributor
Author
|
This is slower; so closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadUint is modified to take a byteBuffer and the file contents
are copied into it. The buf sync pool is created at the controller
level so that it controller determines if it needs one.
Ran a benchmark on pids test.
Earlier:
goos: linux
goarch: amd64
pkg: github.com/containerd/cgroups/v3/cgroup1
cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
BenchmarkPids-8 59758 19905 ns/op 2064 B/op 15 allocs/op
PASS
ok github.com/containerd/cgroups/v3/cgroup1 1.405s
With this change:
goos: linux
goarch: amd64
pkg: github.com/containerd/cgroups/v3/cgroup1
cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
BenchmarkPids-8 57368 21665 ns/op 1345 B/op 13 allocs/op
PASS
ok github.com/containerd/cgroups/v3/cgroup1 1.467s
Inspired from: #275
Signed-off-by: Manu Gupta [email protected]