Skip to content

v2: toggle ancestors of c.path, not c.path itself#124

Merged
estesp merged 2 commits intocontainerd:masterfrom
AkihiroSuda:fix-toggle
Nov 18, 2019
Merged

v2: toggle ancestors of c.path, not c.path itself#124
estesp merged 2 commits intocontainerd:masterfrom
AkihiroSuda:fix-toggle

Conversation

@AkihiroSuda
Copy link
Member

Fix #121

@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #124 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   35.44%   35.35%   -0.09%     
==========================================
  Files          35       35              
  Lines        2370     2376       +6     
==========================================
  Hits          840      840              
- Misses       1397     1403       +6     
  Partials      133      133
Impacted Files Coverage Δ
v2/manager.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8ad43...3022591. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

@AkihiroSuda
Copy link
Member Author

rebased

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit bd09c0d into containerd:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2: ToggleControllers() should toggle ancestors of c.path, not c.path itself

4 participants