Skip to content

v2: fix issues#120

Merged
crosbymichael merged 2 commits intocontainerd:masterfrom
AkihiroSuda:fix-v2-stats
Nov 15, 2019
Merged

v2: fix issues#120
crosbymichael merged 2 commits intocontainerd:masterfrom
AkihiroSuda:fix-v2-stats

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Nov 15, 2019

  • pids stat was not functional due to the whitespace issue
  • nil panic had happened when statting disabled controllers

Signed-off-by: Akihiro Suda [email protected]

pids stat was not functional due to the whitespace issue

Signed-off-by: Akihiro Suda <[email protected]>
@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #120 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   35.46%   35.33%   -0.14%     
==========================================
  Files          32       32              
  Lines        2154     2162       +8     
==========================================
  Hits          764      764              
- Misses       1262     1270       +8     
  Partials      128      128
Impacted Files Coverage Δ
v2/manager.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf5261...c4993ae. Read the comment docs.

@AkihiroSuda AkihiroSuda changed the title v2: fix parsing pids stat v2: fix issues Nov 15, 2019
@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit e56683d into containerd:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants