Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   36.34%   36.34%           
=======================================
  Files          32       32           
  Lines        2102     2102           
=======================================
  Hits          764      764           
  Misses       1210     1210           
  Partials      128      128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4baafdb...d0f61b7. Read the comment docs.

Seems like somewhere in the past 6 days using a mix of go.mod and go get started failing for non-Go 1.13 builds. Since we have a go.mod we might as well use it--switching to go mod vendor from go get .. makes the last 3 Golang releases work properly in Travis CI.

LGTM

@estesp its because we put the package inside GOPATH, and go mod doesnt work prior go 1.13 because the default GO111MODULE=auto will not active go mod inside a GOPATH.

Either one of these things would have make things work:

1. stop manually cloning some dependencies, put this outside of GOPATH, and do go get
2. forcing it to active module support with GO111MODULE=on go get. This is probably the same as GO111MODULE=on go mod vendor here.

I do prefer 1) for go modules project nowadays.

LGTM

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.34%. Comparing base (4baafdb) to head (d0f61b7).

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   36.34%   36.34%           
=======================================
  Files          32       32           
  Lines        2102     2102           
=======================================
  Hits          764      764           
  Misses       1210     1210           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.