Added current and max swap and memory usage stats#117
Added current and max swap and memory usage stats#117crosbymichael merged 4 commits intocontainerd:masterfrom
Conversation
|
I think you will need to rebase on #118 when it is reviewed and merged to get CI passing for all your PRs. |
estesp
changed the title
|
Can you rebase on master as well to fix the build? Thanks! |
Signed-off-by: bpopovschi <[email protected]>
Signed-off-by: bpopovschi <[email protected]>
Signed-off-by: bpopovschi <[email protected]>
Zyqsempai
force-pushed
the
104-add-more-memory-stats
branch
from
a0dd04b to
4d88c26
Compare
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=========================================
- Coverage 36.34% 36.05% -0.3%
=========================================
Files 32 32
Lines 2102 2119 +17
=========================================
Hits 764 764
- Misses 1210 1227 +17
Partials 128 128
Continue to review full report at Codecov.
|
|
@crosbymichael Done. |
v2/utils.go
Outdated
| } | ||
|
|
||
| // Gets uint64 parsed content of single value cgroup stat file | ||
| func getStatFileContent(filePath string) uint64 { |
There was a problem hiding this comment.
nit: function name is not specific, but it only can retrieve uint64 value.
There was a problem hiding this comment.
Also, this should take io.Reader rather than a filepath string and should have unit tests. Can be a follow-up PR.
There was a problem hiding this comment.
Yep, i have in plans to cover everything with unit tests but in separate PR's
There was a problem hiding this comment.
Also, I think that io.Reader parameter here will over complicate using of that function.
Signed-off-by: bpopovschi <[email protected]>
|
LGTM |
6 participants
Related to #104
Added
memory.current, memory.max, memory.swap.current, memory.swap.maxstats.Signed-off-by: bpopovschi [email protected]