-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] cgroup2: the first cut #102
Conversation
397762d
to
5d0860d
Compare
Currently, only PID controller is implemented as an example. Other controllers will be implemented in other PRs. Interface changes: * `Cgroup` interface now excludes V1-specific and V2-specific methods. `type CgroupV1 interface{Cgroup, ...}` extends `Cgroup` for V1-specific methods. Same applies to `type CgroupV2 interface{Cgroup, ...}`. * Now `Hierarchy()` returns whether the hierarchy is in unified-mode or not. `cmd/cgroupsplayground/main.go` is included as an example of the new API. Signed-off-by: Akihiro Suda <[email protected]>
5d0860d
to
b5526ec
Compare
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 45.42% 41.74% -3.68%
==========================================
Files 23 26 +3
Lines 1638 1806 +168
==========================================
+ Hits 744 754 +10
- Misses 768 917 +149
- Partials 126 135 +9
Continue to review full report at Codecov.
|
RFC: when |
We could do this or we can make a new I say this, because if we think of cgroup usage for the next few years, it maybe cleaner to have a "pure" v2 implementation apart from v1 for maintenance |
Do you plan to open PR? |
alternative to containerd#102 v2 package is completely split from v1. Signed-off-by: Akihiro Suda <[email protected]>
opened #103, RFC |
alternative to containerd#102 v2 package is completely split from v1. Signed-off-by: Akihiro Suda <[email protected]>
alternative to containerd#102 v2 package is completely split from v1. Signed-off-by: Akihiro Suda <[email protected]>
alternative to containerd#102 v2 package is completely split from v1. Signed-off-by: Akihiro Suda <[email protected]>
alternative to containerd#102 v2 package is completely split from v1. Signed-off-by: Akihiro Suda <[email protected]>
alternative to containerd#102 v2 package is completely split from v1. Signed-off-by: Akihiro Suda <[email protected]>
Currently, only PID controller is implemented as an example.
Other controllers will be implemented in other PRs.
Interface changes:
Cgroup
interface now excludes V1-specific and V2-specific methods.type CgroupV1 interface{Cgroup, ...}
extendsCgroup
for V1-specific methods.Same applies to
type CgroupV2 interface{Cgroup, ...}
.Hierarchy()
returns whether the hierarchy is in unified-mode or not.cmd/cgroupsplayground/main.go
is included as an example of the new API.