cgroupv2: reset lastErr to nil when subtree control is successfully written

shankerwangmiao · shankerwangmiao · commit 73a8516e7f0f · 2021-07-26T23:40:17.000+08:00
As stated originally in the comment, ``the user may face EPERM on parent
groups", it should not be an error when writing to grand-parent groups fails
but writing to the last one succeeds.

Signed-off-by: Miao Wang &lt;shankerwangmiao@gmail.com&gt;
diff --git a/v2/manager.go b/v2/manager.go
@@ -272,6 +272,8 @@ func (c *Manager) ToggleControllers(controllers []string, t ControllerToggle) er
 			// controller is already written.
 			// So we only return the last error.
 			lastErr = errors.Wrapf(err, "failed to write subtree controllers %+v to %q", controllers, filePath)
+		} else {
+			lastErr = nil
 		}
 	}
 	return lastErr

Original file line number	Diff line number	Diff line change
`@@ -272,6 +272,8 @@ func (c *Manager) ToggleControllers(controllers []string, t ControllerToggle) er`
`272`	`272`	`// controller is already written.`
`273`	`273`	`// So we only return the last error.`
`274`	`274`	`lastErr = errors.Wrapf(err, "failed to write subtree controllers %+v to %q", controllers, filePath)`
	`275`	`+ } else {`
	`276`	`+ lastErr = nil`
`275`	`277`	`}`
`276`	`278`	`}`
`277`	`279`	`return lastErr`