Skip to content

fix make test failed on old kernel when run make test on containerd 1.7#42

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
ningmingxiao:dev1
Dec 29, 2023
Merged

fix make test failed on old kernel when run make test on containerd 1.7#42
samuelkarp merged 1 commit intocontainerd:mainfrom
ningmingxiao:dev1

Conversation

@ningmingxiao
Copy link
Copy Markdown
Contributor

@ningmingxiao ningmingxiao commented Dec 21, 2023 •
edited
Loading

'BUILDTAGS=no_btrfs make test' or 'make test ' on 3.10 kernel for containerd 1.7
will show

# github.com/containerd/btrfs/v2
In file included from vendor/github.com/containerd/btrfs/v2/btrfs.go:23:0:
./btrfs.h:19:2: error: #error "Headers from kernel >= 4.12 are required on compilation time (not on run time)"
 #error "Headers from kernel >= 4.12 are required on compilation time (not on run time)"

BUILDTAGS=no_btrfs is useless
another pr https://github.com/containerd/btrfs/pull/43/files

@ningmingxiao ningmingxiao changed the title fix make test failed on old kernel when run on containerd 1.7 fix make test failed on old kernel when run make test on containerd 1.7 Dec 21, 2023
@ningmingxiao
Copy link
Copy Markdown
Contributor Author

ningmingxiao commented Dec 21, 2023

@AkihiroSuda

@samuelkarp samuelkarp merged commit 2673fd3 into containerd:main Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ningmingxiao @samuelkarp @AkihiroSuda