Skip to content

initial quota support#14

Closed
AkihiroSuda wants to merge 1 commit intocontainerd:mainfrom
AkihiroSuda:q
Closed

initial quota support#14
AkihiroSuda wants to merge 1 commit intocontainerd:mainfrom
AkihiroSuda:q

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

Signed-off-by: Akihiro Suda [email protected]

@AkihiroSuda
Copy link
Copy Markdown
Member Author

temporarily closing, I found QGroupInfo needs to return multiple entries. generally

Comment thread btrfs.go Outdated
return ioctl(fp.Fd(), C.BTRFS_IOC_QUOTA_CTL, uintptr(unsafe.Pointer(&args)))
}

func QGroupInfo(path string) ([]*QGroupInfoItem, error) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't need to pointers.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@stevvooe
Copy link
Copy Markdown
Member

Is there a way to configure quotas or does this just naturally work?

@AkihiroSuda
Copy link
Copy Markdown
Member Author

Is there a way to configure quotas or does this just naturally work?

We can implement BTRFS_IOC_QGROUP_LIMIT later, but not needed for containerd, until we support setting quotas in containerd (v1.1? Or should we hurry to implement this in v1.0?)

Signed-off-by: Akihiro Suda <[email protected]>
@stevvooe
Copy link
Copy Markdown
Member

stevvooe commented Feb 2, 2018

LGTM

@AkihiroSuda AkihiroSuda closed this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants