Fix stray comma after minus sign in HumanFloatCount#815
Merged
djc merged 1 commit intoJun 24, 2026
Conversation
The Display impl grouped digits over the int part including the leading '-', so the sign counted as a digit and a comma landed right after it for sign-aligned lengths: HumanFloatCount(-100.0) rendered "-,100", -100000.0 rendered "-,100,000", and NEG_INFINITY rendered "-,inf". Strip the sign before grouping. Add a regression test for negatives and -inf (it fails before, passes after).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #814
HumanFloatCount'sDisplayimpl grouped the integer digits over the whole int part including the leading-, so the sign was counted as a digit and a comma landed right after it for sign-aligned lengths:HumanFloatCount(-100.0)→"-,100"HumanFloatCount(-100000.0)→"-,100,000"HumanFloatCount(f64::NEG_INFINITY)→"-,inf"(
-1000.0only looked right because the sign offset coincides with a real group boundary.)The fix splits the optional sign off before grouping and writes it first; positive numbers are unchanged.
Added
human_float_count_negativecovering negatives and-inf. It fails on the current code (left "-100"/right "-,100") and passes with the change.cargo test,cargo fmt --check, andcargo clippyare clean.