Exclude development scripts from published package#278
Merged
djc merged 3 commits intoconsole-rs:mainfrom Dec 16, 2025
Merged
Conversation
During a dependency review we noticed that the commit crate includes various development scripts. These development scripts shouldn't be there as they might, at some point become problematic. As of now they prevent any downstream user from enabling the `[bans.build.interpreted]` option of cargo deny. I opted for using an explicit include list instead of an exclude list to prevent these files from being included in the published packages to make sure that everything that's included is an conscious choice.
djc
approved these changes
Dec 16, 2025
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
LGTM, can you fix up the formatting in the second commit?
If you want a release with this, please tack on a version bump commit.
weiznich
force-pushed
the
exclude_scripts
branch
from
871c194 to
dd141ff
Compare
Contributor
Author
|
Thanks for the fast response. This should be the last PR from me today, I'm done with my list 🎉 |
djc
approved these changes
Dec 16, 2025
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Dec 17, 2025
Bumps console from 0.16.1 to 0.16.2. Release notes Sourced from console's releases. 0.16.2 What's Changed Implement basic support for true colors by @lord-haffi in console-rs/console#271 docs: add note about clicolors by @philbucher in console-rs/console#274 chore: minor improvement for docs by @spuradage in console-rs/console#276 Exclude development scripts from published package by @weiznich in console-rs/console#278 Commits 0bf645d Bump version 0b789b9 Fix clippy warnings bb1cbdb Exclude development scripts from published package 12281c1 chore: minor improvement for docs e611fbc docs: add note about clicolors e9b9a44 Apply clippy suggestion 9cf0c5f ci: enable all workflows for pull requests 761e0f2 Implement basic support for true colors (#271) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a dependency review we noticed that the commit crate includes various development scripts. These development scripts shouldn't be there as they might, at some point become problematic. As of now they prevent any downstream user from enabling the
[bans.build.interpreted]option of cargo deny.I opted for using an explicit include list instead of an exclude list to prevent these files from being included in the published packages to make sure that everything that's included is an conscious choice.