This repository was archived by the owner on Dec 20, 2023. It is now read-only.
BundleOverride with ipc-actors type for automatic loading#72
Merged
adlrocha merged 8 commits intobundle_genesisfrom Feb 16, 2023
Merged
BundleOverride with ipc-actors type for automatic loading#72adlrocha merged 8 commits intobundle_genesisfrom
ipc-actors type for automatic loading#72adlrocha merged 8 commits intobundle_genesisfrom
Conversation
dnkolegov
approved these changes
Feb 13, 2023
Contributor
dnkolegov
left a comment
dnkolegov
left a comment
There was a problem hiding this comment.
LGTM! But fix linting errors please!
…-actor Deploy IPC Subnet actor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #71
Goal
Remove the need of having to set the
LOTUS_BUILTIN_ACTORS_V10_BUNDLEevery time that we run Eudico. The default bundle for eudico should be the one including the IPC actors, because the gateway is spawned in genesis, and if we don't set a bundle including the IPC actors running eudico will always fail.Implementation
To do this we pass a new Override of type
ipc-actorsto tell Lotus that from a specific network version it should override the actor bundle with the one including the IPC actors. This is the cleanest approach I could find to ship the bundle with the right version of our actor bundle and avoid major changes in the Lotus code to prevent future rebasing pains (thus the use ofgo:embedand a "fake path" to trigger the loading).It is worth noting that as the default behavior is to spawn the gateway actor in genesis, not using an IPC-compatible bundle will break eudico. This can be easily fixed by adding a flag to determine the type of bundle being used, but I don't think it is worth at this point (but happy to be convinced otherwise).