Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct content structure for tests and default components #6

Merged
merged 3 commits into from
Feb 10, 2019

Conversation

connor-baer
Copy link
Owner

Purpose

I was using a flattened content structure in the test fixtures and for the default asset components.

Approach and changes

  • Update content structure of fixtures
  • Destructure props according to the proper content structure in the default components

@connor-baer connor-baer added the bug Something isn't working label Feb 10, 2019
@codecov
Copy link

codecov bot commented Feb 10, 2019

Codecov Report

Merging #6 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   98.86%   98.89%   +0.03%     
==========================================
  Files          13       13              
  Lines         176      181       +5     
  Branches       49       48       -1     
==========================================
+ Hits          174      179       +5     
  Misses          2        2
Impacted Files Coverage Δ
src/components/Image/Image.js 100% <100%> (ø) ⬆️
src/__fixtures__/index.js 100% <100%> (ø)
src/components/Audio/Audio.js 100% <100%> (ø) ⬆️
src/components/AssetLink/AssetLink.js 100% <100%> (+25%) ⬆️
src/rich-text-to-jsx.js 97.56% <100%> (-1.24%) ⬇️
src/components/Video/Video.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c43057...8580d95. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 10, 2019

Codecov Report

Merging #6 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   98.86%   98.89%   +0.03%     
==========================================
  Files          13       13              
  Lines         176      181       +5     
  Branches       49       48       -1     
==========================================
+ Hits          174      179       +5     
  Misses          2        2
Impacted Files Coverage Δ
src/components/Image/Image.js 100% <100%> (ø) ⬆️
src/__fixtures__/index.js 100% <100%> (ø)
src/components/Audio/Audio.js 100% <100%> (ø) ⬆️
src/components/AssetLink/AssetLink.js 100% <100%> (+25%) ⬆️
src/rich-text-to-jsx.js 97.56% <100%> (-1.24%) ⬇️
src/components/Video/Video.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c43057...8580d95. Read the comment docs.

@connor-baer connor-baer merged commit ad292fe into master Feb 10, 2019
@connor-baer connor-baer deleted the tests/moar-tests branch February 10, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant