Add default elements for table node types #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 99.08% 99.11% +0.02%
==========================================
Files 13 14 +1
Lines 219 225 +6
Branches 62 63 +1
==========================================
+ Hits 217 223 +6
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #213.
Purpose
Contentful added support for tables to Rich Text a while ago. While it's already been possible to render tables using overrides, this PR adds default elements to support tables out of the box.
Approach and changes
BLOCKS.TABLE:<table><tbody>...</tbody></table>BLOCKS.TABLE_ROW:<tr>BLOCKS.TABLE_HEADER_CELL:<th>BLOCKS.TABLE_CELL:<td>