Skip to content

Add forward declaration to fix compilation without ssl#4794

Merged
Emanuele Sabellico (emasab) merged 3 commits intoconfluentinc:masterfrom
emasab:dev_fix_compile_without_ssl
Aug 5, 2024
Merged

Add forward declaration to fix compilation without ssl#4794
Emanuele Sabellico (emasab) merged 3 commits intoconfluentinc:masterfrom
emasab:dev_fix_compile_without_ssl

Conversation

@emasab
Copy link
Copy Markdown
Contributor

@emasab Emanuele Sabellico (emasab) commented Jul 25, 2024

Closes #4793

@emasab Emanuele Sabellico (emasab) requested a review from a team as a code owner July 25, 2024 08:05
@emasab Emanuele Sabellico (emasab) changed the title Add forward definition to fix compilation without ssl Add forward declaration to fix compilation without ssl Jul 25, 2024
Comment on lines +2 to +7
set -e
./configure --install-deps --disable-ssl --disable-gssapi \
--disable-curl --disable-zlib \
--disable-zstd --disable-lz4-ext --disable-regex-ext \
--disable-c11threads --disable-syslog
make -j
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain more on what are we trying to do here in comment.

Copy link
Copy Markdown
Member

@pranavrth Pranav Rathi (pranavrth) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!.

@emasab Emanuele Sabellico (emasab) merged commit d72576a into confluentinc:master Aug 5, 2024
Nikhil Benesch (benesch) pushed a commit to MaterializeInc/librdkafka that referenced this pull request Aug 31, 2024
David Blewett (davidblewett) pushed a commit to DataDog/librdkafka that referenced this pull request Oct 3, 2024
airlock-confluentinc Bot pushed a commit that referenced this pull request Nov 28, 2024
and add build checks with different configurations
Anchit Jain (anchitj) added a commit that referenced this pull request Dec 15, 2024
* Fix for idempotent producer fatal errors, triggered after a possibly persisted message state (#4438)

* Remove CentOS 6 and CentOS 7 binaries (#4775)

*Remove CentOS 6 and 7 support as discontinued, keeps
  using manylinux_2_28 based on AlmaLinux 8 (CentOS 8)
* Remove fix for CentOS 6
* Add CHANGELOG entry
* Upgrade test and verify package creation or installation
   using clients repository

* Upgrade msvcr140 and vcpkg dependencies (#4872)

* Add forward declaration to fix compilation without ssl (#4794)

and add build checks with different configurations

* PR comments

* Add files for lz4 1.9.4 (#4726)

* Add files for lz4 1.9.4

* Update changelog.md

* rdxxhash should not be in clang-format list

* Add instructions and update memory alloc/free

* Update instructions for lz4

* NONJAVACLI-3460: update dependencies (#4706)

* update third party dependencies
* update lz4 version in the header file
* update libraries for the windows build
* reverting the version bump in the headers
* use the latest version of curl
* Update OpenSSL and add CHANGELOG.md
* downgade curl version to one available via vcpkg
* downgrade zlib to last available version in vcpkg
* downgrade zstd to the latest available
* Include CPPFLAGS within make for libcurl
* Update mklove/modules/configure.libcurl
* Update CHANGELOG.md

---------

Co-authored-by: Milind L <[email protected]>
Co-authored-by: Emanuele Sabellico <[email protected]>

* Upgrade linux dependencies (#4875)

* Security upgrade for OpenSSL and Curl, CVEs fixed:

OpenSSL
- CVE-2024-2511
- CVE-2024-4603
- CVE-2024-4741
- CVE-2024-5535
- CVE-2024-6119

CURL
- CVE-2024-8096
- CVE-2024-7264
- CVE-2024-6874
- CVE-2024-6197

* Fix for curl configure failure caused by
curl/curl#14373

* Include NOTE in CHANGELOG

* Update RD_KAFKA_VERSION in rdkafkacpp.h

---------

Co-authored-by: Emanuele Sabellico <[email protected]>
Co-authored-by: Milind L <[email protected]>
Co-authored-by: Jan Werner <[email protected]>
Co-authored-by: Milind L <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to build without SSL since #4721

2 participants