ListOffsetsRequest should only be sent to the leader replica (CI)#4754
Conversation
Emanuele Sabellico (emasab)
changed the title
|
Emanuele Sabellico (@emasab) do you think this PR could be merged soon? I saw there were some CI issues on previous iterations of this PR but this one looks green |
Milind L (milindl)
left a comment
Milind L (milindl)
left a comment
There was a problem hiding this comment.
Thanks Kyle Phelps (@kphelps) and Emanuele Sabellico (@emasab) . Looks good to me bar a few minor documentation related things.
| else | ||
| test_consumer_poll(auto_offset_reset, c, 0, 1, 0, msgcnt, NULL); | ||
|
|
||
| /* send another batch of messages to ensure the consumer isn't stuck */ |
There was a problem hiding this comment.
I think it's a good idea to expand on why exactly we add this and why the consumer was getting stuck, alternatively, we can provide the issue # . Without that, it'll be a bit difficult for future readers.
| * Fix segfault when using long client id because of erased segment when using flexver. (#4689) | ||
| * Update bundled lz4 (#4726) | ||
| * Fix segfault when using long client id because of erased segment when using flexver. (#4689) | ||
| * Fix for a loop of ListOffset requests, happening in a Fetch From Follower |
There was a problem hiding this comment.
Fix changelog for this to be in 2.5.1
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
Bot
force-pushed
the
dev_kphelps_list-offsets-leader
branch
2 times, most recently
from
4d463c9 to
89369d8
Compare
airlock-confluentinc
Bot
force-pushed
the
dev_kphelps_list-offsets-leader
branch
from
89369d8 to
7d09ee5
Compare
Emanuele Sabellico (emasab)
deleted the
dev_kphelps_list-offsets-leader
branch
4 participants
Continuation of #4616 from an internal branch due to CI issues