Skip to content

Add files for lz4 1.9.4#4726

Merged
Milind L (milindl) merged 6 commits intomasterfrom
dev_update_lz4_1.9.4
Jun 6, 2024
Merged

Add files for lz4 1.9.4#4726
Milind L (milindl) merged 6 commits intomasterfrom
dev_update_lz4_1.9.4

Conversation

@milindl
Copy link
Copy Markdown
Contributor

Updates lz4 from 1.9.3 -> 1.9.4

Process:

  • clean copy of all the lz4* files from 1.9.4 checkout of lz4 into the librdkafka src directory
  • copy of xxhash files into rdxxhash files in the same way
  • change any refs to xxhash within lz4* files into rdxxhash
  • Update changelog and licenses, and configure file
  • Run 0017 (compression test)

@milindl Milind L (milindl) requested a review from a team May 22, 2024 05:12
Comment thread src/lz4.c
# define ALLOC(s) lz4_error_memory_allocation_is_disabled
# define ALLOC_AND_ZERO(s) lz4_error_memory_allocation_is_disabled
# define FREEMEM(p) lz4_error_memory_allocation_is_disabled
#elif defined(LZ4_USER_MEMORY_FUNCTIONS)
Copy link
Copy Markdown
Contributor

@emasab Emanuele Sabellico (emasab) Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous version 1.9.3 had this part of the code changed to use rd_kafka_mem_malloc ,.... let's keep the same and add a comment to do that when upgrading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this and added upgrade instructions for future developers.

Copy link
Copy Markdown
Member

@pranavrth Pranav Rathi (pranavrth) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.!

@milindl Milind L (milindl) merged commit 2fe647b into master Jun 6, 2024
@milindl Milind L (milindl) deleted the dev_update_lz4_1.9.4 branch June 6, 2024 11:26
airlock-confluentinc Bot pushed a commit that referenced this pull request Dec 15, 2024
* Add files for lz4 1.9.4

* Update changelog.md

* rdxxhash should not be in clang-format list

* Add instructions and update memory alloc/free

* Update instructions for lz4
Anchit Jain (anchitj) added a commit that referenced this pull request Dec 15, 2024
* Fix for idempotent producer fatal errors, triggered after a possibly persisted message state (#4438)

* Remove CentOS 6 and CentOS 7 binaries (#4775)

*Remove CentOS 6 and 7 support as discontinued, keeps
  using manylinux_2_28 based on AlmaLinux 8 (CentOS 8)
* Remove fix for CentOS 6
* Add CHANGELOG entry
* Upgrade test and verify package creation or installation
   using clients repository

* Upgrade msvcr140 and vcpkg dependencies (#4872)

* Add forward declaration to fix compilation without ssl (#4794)

and add build checks with different configurations

* PR comments

* Add files for lz4 1.9.4 (#4726)

* Add files for lz4 1.9.4

* Update changelog.md

* rdxxhash should not be in clang-format list

* Add instructions and update memory alloc/free

* Update instructions for lz4

* NONJAVACLI-3460: update dependencies (#4706)

* update third party dependencies
* update lz4 version in the header file
* update libraries for the windows build
* reverting the version bump in the headers
* use the latest version of curl
* Update OpenSSL and add CHANGELOG.md
* downgade curl version to one available via vcpkg
* downgrade zlib to last available version in vcpkg
* downgrade zstd to the latest available
* Include CPPFLAGS within make for libcurl
* Update mklove/modules/configure.libcurl
* Update CHANGELOG.md

---------

Co-authored-by: Milind L <[email protected]>
Co-authored-by: Emanuele Sabellico <[email protected]>

* Upgrade linux dependencies (#4875)

* Security upgrade for OpenSSL and Curl, CVEs fixed:

OpenSSL
- CVE-2024-2511
- CVE-2024-4603
- CVE-2024-4741
- CVE-2024-5535
- CVE-2024-6119

CURL
- CVE-2024-8096
- CVE-2024-7264
- CVE-2024-6874
- CVE-2024-6197

* Fix for curl configure failure caused by
curl/curl#14373

* Include NOTE in CHANGELOG

* Update RD_KAFKA_VERSION in rdkafkacpp.h

---------

Co-authored-by: Emanuele Sabellico <[email protected]>
Co-authored-by: Milind L <[email protected]>
Co-authored-by: Jan Werner <[email protected]>
Co-authored-by: Milind L <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants