KIP 714 with compression support#4721
Merged
Anchit Jain (anchitj) merged 99 commits intomasterfrom Jul 8, 2024
Merged
Conversation
* WIP:Push telemetry is being scheduled now. * Push * Compliation Fix * Working * Use UUID in PUSH * Remove fprintf * Changes * Fix CONFIGURATION.md * Fix size * Update s2i bounds --------- Co-authored-by: Milind L <[email protected]>
* Add broker selection and client termination * Address review comments
* Serialise metrics using nanopb * Move nanopb and opentelemetry inside src * Add metrics.options file * Remove unused includes * Style fix * Fix formatting * Skip copyright check * Add nanopb and opentelemetry in windows vcxproj * Include headers directories in CMAKE * Use flexver with PushTelemetry * Fix memory leaks * Change import path * Use rd_bool_t everywhere * Fix librdkafka.vcxproj * Use rd_bool_t * PR Feedback * Add nanopb license * Include opentelemtry license
* Support for delta temporality * Style fix * Fix bugs * Fix memory leaks and formatting * Fixes * PR Feedback
* Add telemetry encode and decode unit tests * Style fix * Improve test * PR Feedback
* Add max telemetry bytes * Clear telemetry_max_bytes * PR comments
…master_merge_with_compression
Emanuele Sabellico (emasab)
requested changes
Jul 3, 2024
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
Comments about encode and decode
Emanuele Sabellico (emasab)
requested changes
Jul 3, 2024
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
Most of remaining comments
Emanuele Sabellico (emasab)
requested changes
Jul 4, 2024
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
Comments about unit tests and naming
Emanuele Sabellico (emasab)
requested changes
Jul 5, 2024
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
Copyright and includes comments
| #ifndef _RDKAFKA_RDKAFKA_TELEMETRY_ENCODE_H | ||
| #define _RDKAFKA_RDKAFKA_TELEMETRY_ENCODE_H | ||
|
|
||
| #include "rdtypes.h" |
Contributor
There was a problem hiding this comment.
Add #include "rdkafka_int.h" as it's needed for rd_kafka_t
Suggested change
| #include "rdtypes.h" | |
| #include "rdkafka_int.h" | |
| #include "rdtypes.h" |
|
|
||
|
|
||
| #ifndef _RD_KAFKA_TELEMETRY_H_ | ||
| #define _RD_KAFKA_TELEMETRY_H_ |
Contributor
There was a problem hiding this comment.
Required for rd_kafka_t
Suggested change
| #define _RD_KAFKA_TELEMETRY_H_ | |
| #define _RD_KAFKA_TELEMETRY_H_ | |
| #include "rdkafka_int.h" |
Contributor
|
Please add these to the list of |
Emanuele Sabellico (emasab)
requested changes
Jul 7, 2024
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
Some comments about placeholders types in formatted strings
Anchit Jain (anchitj)
force-pushed
the
dev_kip_714_mock_broker_integration_tests_master_merge_with_compression
branch
from
9616eba to
4732ff6
Compare
Emanuele Sabellico (emasab)
approved these changes
Jul 8, 2024
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
Awesome work, thanks Anchit Jain (@anchitj) and Milind L (@milindl) !
Anchit Jain (anchitj)
deleted the
dev_kip_714_mock_broker_integration_tests_master_merge_with_compression
branch
|
Hmm... Anchit Jain (@anchitj) Emanuele Sabellico (@emasab) what do you think? |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.