Add max telemetry bytes#4507
Merged
Anchit Jain (anchitj) merged 3 commits intodev_kip_714from Dec 6, 2023
Merged
Conversation
Milind L (milindl)
approved these changes
Dec 4, 2023
Contributor
Milind L (milindl)
left a comment
Milind L (milindl)
left a comment
There was a problem hiding this comment.
Looks okay - just a bunch of minor stuff
| rd_kafka_log( | ||
| rk, LOG_WARNING, "TELEMETRY", | ||
| "Metrics payload size %" PRIdsz | ||
| " exceeds telemetry_max_bytes %d specified by the broker.", |
Contributor
There was a problem hiding this comment.
The format string will PRId32 for int32
Contributor
Author
There was a problem hiding this comment.
Updated
| "PushTelemetryRequest failed: %s", | ||
| rd_kafka_err2str(err)); | ||
| // Non-retriable errors | ||
| // TODO: What to do for TELEMETRY_TOO_LARGE? |
Contributor
There was a problem hiding this comment.
I guess we can just add a comment. Or at max a log (even though we will have logged a warning already), based on the discussion with the Java clients team, we need to do nothing special.
Contributor
Author
There was a problem hiding this comment.
Removed the comment
Anchit Jain (anchitj)
force-pushed
the
dev_kip_714_telemetry_bytes
branch
from
0230c2c to
a6b31a4
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.