Fix timeout for rd_kafka_query_watermark_offsets#4460
Merged
Emanuele Sabellico (emasab) merged 6 commits intomasterfrom Oct 11, 2023
Merged
Fix timeout for rd_kafka_query_watermark_offsets#4460Emanuele Sabellico (emasab) merged 6 commits intomasterfrom
Emanuele Sabellico (emasab) merged 6 commits intomasterfrom
Conversation
Milind L (milindl)
requested review from
Emanuele Sabellico (emasab) and
Pranav Rathi (pranavrth)
Emanuele Sabellico (emasab)
requested changes
Oct 10, 2023
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
Thanks for the fix! Just some test changes to ensure it's run when the test run has the local flag
Co-authored-by: Emanuele Sabellico <[email protected]>
Contributor
Author
|
Addressed comments, thanks for review Emanuele Sabellico (@emasab) |
Emanuele Sabellico (emasab)
approved these changes
Oct 11, 2023
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
Thanks Milind L (@milindl) !
Emanuele Sabellico (emasab)
deleted the
dev_fix_query_watermark_offsets_timeout
branch
This was referenced Feb 28, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rd_kafka_query_watermark_offsetshangs forever if say, the broker is down, and exceeds the timeout in case the RTT > timeout, see the linked issue.This PR adds a failing test, and then fixes the issue.
This also changes the fact the return value of
rd_kafka_q_servewas being compared to RD_KAFKA_OP_RES_YIELD, which doesn't make sense to me, since it returns the count of served ops, and RD_KAFKA_OP_RES_YIELD is a positive constant.Fixes #2588.