Skip to content

Refactored tmpabuf and fixed an insufficient buffer allocation#4449

Merged
Emanuele Sabellico (emasab) merged 3 commits intomasterfrom
dev_tmpabuf_refactor_and_fix
Sep 28, 2023
Merged

Refactored tmpabuf and fixed an insufficient buffer allocation#4449
Emanuele Sabellico (emasab) merged 3 commits intomasterfrom
dev_tmpabuf_refactor_and_fix

Conversation

@emasab
Copy link
Copy Markdown
Contributor

Closes #4398

@emasab Emanuele Sabellico (emasab) marked this pull request as ready for review September 27, 2023 09:13
@emasab Emanuele Sabellico (emasab) changed the title Refactored tmpabuf refactor and fixed an insufficient buffer allocation Refactored tmpabuf and fixed an insufficient buffer allocation Sep 27, 2023
Comment thread src/rdkafka_buf.h
Comment thread CHANGELOG.md Outdated
@wolfchimneyrock
Copy link
Copy Markdown
Contributor

Thanks Emanuele Sabellico (@emasab). I can confirm that this PR fixes #4398 for me.

If its possible, do you mind either:

  1. squashing all three commits together
  2. having two commits - only with just the code update, one with just the documentation update

that would make it easier for me to backport this.

@emasab
Copy link
Copy Markdown
Contributor Author

Emanuele Sabellico (emasab) commented Sep 28, 2023

Thank you Robert Wagner (@wolfchimneyrock).
Sure, I'll squash when merging.

@emasab Emanuele Sabellico (emasab) deleted the dev_tmpabuf_refactor_and_fix branch September 28, 2023 14:30
Axel Andersson (axelandersson) added a commit to axelandersson/librdkafka that referenced this pull request Oct 5, 2023
* upstream/master:
  librdkafka v2.3.0 (confluentinc#4455)
  Fix for idempotent producer fatal errors, triggered after a possibly persisted message state (confluentinc#4438)
  Move can_q_contain_fetched_msgs inside q_serve (confluentinc#4431)
  [KIP-580] Exponential Backoff with Mock Broker Changes to Automate Testing. (confluentinc#4422)
  Update only the mklove version of OpenSSL to 3.0.11 (confluentinc#4454)
  Permanent errors during offset validation should be retried (confluentinc#4447)
  Increased flexver request size for Metadata request to include topic_id size (confluentinc#4453)
  Fix loop of OffsetForLeaderEpoch requests on quick leader changes (confluentinc#4433)
  Fix for stored offsets not being committed if they lacked the leader epoch (confluentinc#4442)
  Add leader epoch to control messages (confluentinc#4434)
  Refactored tmpabuf and fixed an insufficient buffer allocation (confluentinc#4449)
  Work around KIP-700 restrictions for DescribeCluster [KIP-430]
  [admin] KIP-430: Add authorized operations to describe API
  Fix segfault if assignor state is NULL, (confluentinc#4381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rd_kafka_topic_info_new_with_rack insufficient buffer allocation

3 participants