Dev kip235#4307
Closed
Anchit Jain (anchitj) wants to merge 14 commits intomasterfrom
Closed
Conversation
Pranav Rathi (pranavrth)
requested changes
Jun 8, 2023
| RD_SOCKADDR_LIST_FOREACH(sinx, sockaddrList) { | ||
| resolvedFQDN = rd_sockaddr2str( | ||
| sinx, RD_SOCKADDR2STR_F_RESOLVE); | ||
| rd_kafka_find_or_add_broker( |
There was a problem hiding this comment.
Can we add a debug statement here as well for resolvedFQDN?
| int pre_cnt = rd_atomic32_get(&rk->rk_broker_cnt); | ||
| int pre_cnt = rd_atomic32_get(&rk->rk_broker_cnt); | ||
| rd_sockaddr_inx_t *sinx; | ||
| rd_sockaddr_list_t *sockaddrList; |
There was a problem hiding this comment.
lets not use camelCase here. Better to use same convention which is being used in librdkafka. sockaddr_list
| uint16_t port; | ||
| const char *host; | ||
| const char *errstr; | ||
| const char *resolvedFQDN; |
There was a problem hiding this comment.
same. use snake_case.
| "Canonicalizing bootstrap broker %s:%d", | ||
| host, port); | ||
| sockaddrList = rd_getaddrinfo( | ||
| host, RD_KAFKA_PORT_STR, AI_ADDRCONFIG, |
There was a problem hiding this comment.
Don't we need to use AI_CANONNAME flag here? I think we are only concerned about canonical host name. Other should be discarded. https://man7.org/linux/man-pages/man3/getaddrinfo.3.html
| break; | ||
|
|
||
| rd_kafka_wrlock(rk); | ||
| if (rk->rk_conf.enable_bootstrap_servers_canonical_resolve) { |
There was a problem hiding this comment.
Shouldn't this logic should be in resolve function? We are just adding host names here.
Anchit Jain (anchitj)
force-pushed
the
dev_kip235
branch
from
b74cbd4 to
db5702a
Compare
Anchit Jain (anchitj)
force-pushed
the
dev_kip235
branch
3 times, most recently
from
086fc08 to
e96ef9d
Compare
Anchit Jain (anchitj)
force-pushed
the
dev_kip235
branch
from
dec5455 to
5c9b33b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.