Scram Config API in Admin Client [KIP-554] <- various changes#4306
Merged
Emanuele Sabellico (emasab) merged 28 commits intofeature/userscram-AdminClientfrom Jul 6, 2023
Merged
Conversation
other places where it's listed
remove return values from admin functions
internal enum
always return from async functions through the queue
contains pointers. Renamed rd_kafka_UserScramCredentialAlterationResultElement to rd_kafka_AlterUserScramCredentials_result_response following admin api conventions
create random salt if not provided, move hmac so sasl isn't required, allow multiple alterations for the same user as in Java, example taking parameters from command line
use compact bytes for serialization
Emanuele Sabellico (emasab)
force-pushed
the
feature/userscram-AdminClient-changes
branch
from
2825037 to
9fc8788
Compare
Emanuele Sabellico (emasab)
requested review from
mahajanadhitya and
Milind L (milindl)
Milind L (milindl)
requested changes
Jun 22, 2023
Contributor
Milind L (milindl)
left a comment
Milind L (milindl)
left a comment
There was a problem hiding this comment.
Thank you for this change.
…dminClient-changes
use rd_strcmp2 LICENCE auto fix
Emanuele Sabellico (emasab)
force-pushed
the
feature/userscram-AdminClient-changes
branch
from
211e4e4 to
1c72fc2
Compare
Milind L (milindl)
approved these changes
Jul 6, 2023
Emanuele Sabellico (emasab)
deleted the
feature/userscram-AdminClient-changes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've included a set of commits with some changes, mainly code style, naming.
There's also the support for COMPACT BYTES, as passing a string would exclude the NULL byte from being used as salt or password.
Other things: