Add Topic Id to Metadata Response#4300
Merged
Pranav Rathi (pranavrth) merged 7 commits intomasterfrom Aug 7, 2023
Merged
Conversation
Member
Author
|
There were 2 different places where base64 encoding was done in the code. Both of them are dependent on OpenSSL. I have moved 1 implementation to common place to be used as a generic base64 encoder. Open points to discuss:
|
Pranav Rathi (pranavrth)
force-pushed
the
dev_metadata-response-topic-id
branch
from
6795ad5 to
1c9e5c2
Compare
Pranav Rathi (pranavrth)
force-pushed
the
dev_metadata-response-topic-id
branch
2 times, most recently
from
b6a7b45 to
b32bb78
Compare
Pranav Rathi (pranavrth)
force-pushed
the
dev_metadata-response-topic-id
branch
from
5073a8c to
895358a
Compare
|
|
Emanuele Sabellico (emasab)
added a commit
that referenced
this pull request
Aug 3, 2023
Needs to be updated after #4300
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
Sent some other improvements
| @@ -1,5 +1,11 @@ | |||
| # librdkafka v2.2.0 | |||
Contributor
There was a problem hiding this comment.
version 2.2.1 for the moment as it doesn't change public API
Member
Author
There was a problem hiding this comment.
Keeping 2.3.0 as we don't have plan for 2.2.1 right now.
Emanuele Sabellico (emasab)
approved these changes
Aug 7, 2023
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
Thanks for the PR Pranav Rathi (@pranavrth) !
Emanuele Sabellico (emasab)
added a commit
that referenced
this pull request
Aug 7, 2023
Needs to be updated after #4300
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of KIP-516, we need to add support for
topic idin all the major APIs. As a prerequisite for KIP-848, we are adding topic id to Metadata Response in this PR. We are incrementing support for v12 for Metadata protocol though we still don't support topic id in Metadata Request for now. That will be added once we implement full support for topic id as part of KIP-516.This PR includes: