Add KIP-235 implementation#4292
Merged
Emanuele Sabellico (emasab) merged 14 commits intomasterfrom Jul 7, 2023
Merged
Conversation
Anchit Jain (anchitj)
changed the title
Pranav Rathi (pranavrth)
requested changes
Jun 5, 2023
Pranav Rathi (pranavrth)
requested changes
Jun 8, 2023
Anchit Jain (anchitj)
force-pushed
the
kip235
branch
from
b74cbd4 to
92068d1
Compare
Contributor
Author
|
Semaphore PR corresponding - #4307 |
Anchit Jain (anchitj)
force-pushed
the
kip235
branch
from
b7f736c to
b094e5b
Compare
Anchit Jain (anchitj)
force-pushed
the
kip235
branch
from
086fc08 to
e96ef9d
Compare
Member
|
Update supported kips section as well here |
Pranav Rathi (pranavrth)
requested changes
Jun 13, 2023
Contributor
Author
Anchit Jain (anchitj)
left a comment
Anchit Jain (anchitj)
left a comment
There was a problem hiding this comment.
Updated the supported KIPs section as well
Contributor
Author
|
Verified from that all the tests except 0017_compression work when running individually from This above error is occurring even when running with the latest master, so is unrelated to the PR. |
Pranav Rathi (pranavrth)
approved these changes
Jun 13, 2023
Member
There was a problem hiding this comment.
LGTM! Nice Work.
Just a couple of points we need to confirm with Emanuele Sabellico (@emasab).
Anchit Jain (anchitj)
force-pushed
the
kip235
branch
from
dec5455 to
5c9b33b
Compare
Member
|
Correct the description of the PR. |
Emanuele Sabellico (emasab)
approved these changes
Jul 7, 2023
Contributor
Emanuele Sabellico (emasab)
left a comment
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
LGTM too, thanks Anchit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes done
Add functionality to support KIP-235. Kept the implementation similar to the Java client in apache/kafka#4485
resolve.canonical.bootstrap.servers.only. User should enable this if they are specifying DNS aliases in the bootstrap servers.Testing
Manually. Adding automated test will probably need some sort of integration with a mock DNS server within librdkafka.
Steps:
./../../scripts/cli/playground run -f start.sh --disable-ksqldb --disable-control-center./etc/hostsfile add two new lines, replacing172.18.0.5with the actual address of the broker container.randomExample.com:9092andclient.dns.lookupset toresolve_canonical_bootstrap_servers_onlyto connect with the Kerberos protected Kafka broker.client.dns.lookupis not set, the client is unable to connect with the broker.