Metadata refactor to add internal fields#4279
Merged
Milind L (milindl) merged 6 commits intodev_kip881_all_protocol_changesfrom May 15, 2023
Merged
Conversation
store private metadata into a struct that contains the public one.
Replaced by rd_kafka_metadata_internal_t
remove internal accessors.
Contributor
Milind L (milindl)
left a comment
Milind L (milindl)
left a comment
There was a problem hiding this comment.
Thanks for making this change!
Add internal accessor function for that.
for rd_kafka_metadata_get_internal
Milind L (milindl)
approved these changes
May 15, 2023
Milind L (milindl)
deleted the
dev_kip881_all_protocol_changes_metadata_refactor
branch
Milind L (milindl)
added a commit
that referenced
this pull request
May 16, 2023
* Change embedded MemberMetadata protocol [KIP-881] * Change parsing of Metadata to extract broker racks [KIP-881] * Metadata refactor to add internal fields (#4279) * Metadata and leader epoch refactor. store private metadata into a struct that contains the public one. Co-authored-by: Emanuele Sabellico <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The additional memory is allocated after the public struct and freed together with it, along with nested array memory, through the usage of
rd_tmpabuf_t.mdit->brokersare sorted bymdit->brokers[i].idmdit->topics[i].partitionsare sorted bymdit->topics[i].partitions[j].id.