Incremental alter configs implementation [KIP-339] #4110
Merged
Emanuele Sabellico (emasab) merged 34 commits intomasterfrom Jul 10, 2023
Merged
Incremental alter configs implementation [KIP-339] #4110Emanuele Sabellico (emasab) merged 34 commits intomasterfrom
Emanuele Sabellico (emasab) merged 34 commits intomasterfrom
Conversation
Prasanth Vemula (PrasanthV454)
requested review from
a team and
Magnus Edenhill (edenhill)
Prasanth Vemula (PrasanthV454)
force-pushed
the
feature/incremental-alter-KIP339
branch
from
f202256 to
c164e25
Compare
Prasanth Vemula (PrasanthV454)
requested review from
Emanuele Sabellico (emasab),
Milind L (milindl) and
Pranav Rathi (pranavrth)
and removed request for
Magnus Edenhill (edenhill)
Contributor
Milind L (milindl)
left a comment
Milind L (milindl)
left a comment
There was a problem hiding this comment.
Did a first-pass review, will look into this again later
Emanuele Sabellico (emasab)
force-pushed
the
feature/incremental-alter-KIP339
branch
from
0e2fdf9 to
3c746e5
Compare
ConfigEntry before it fails on the broker or when parsing the result
Emanuele Sabellico (emasab)
force-pushed
the
feature/incremental-alter-KIP339
branch
from
3d1f233 to
fddd40e
Compare
Emanuele Sabellico (emasab)
changed the title
Emanuele Sabellico (emasab)
changed the title
rd_kafka_resp_err_t in new functions
incremental alter configs
to rd_kafka_ConfigResource_set_incremental_config
Pranav Rathi (pranavrth)
requested changes
Jun 23, 2023
Member
Pranav Rathi (pranavrth)
left a comment
Pranav Rathi (pranavrth)
left a comment
There was a problem hiding this comment.
First round of review related to example, test and structs. Checking implementation in details.
Pranav Rathi (pranavrth)
requested changes
Jul 3, 2023
Pranav Rathi (pranavrth)
approved these changes
Jul 3, 2023
Member
Pranav Rathi (pranavrth)
left a comment
Pranav Rathi (pranavrth)
left a comment
There was a problem hiding this comment.
Good Work.
LGTM!
tests only with broker version >= 2.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KIP-339 Incremental Alter Configs Implementation.
Supporting Set, Remove, Append and Subtract Operations.