Skip to content

KAFKA-10289; Fix failed connect_distributed_test.py (ConnectDistribut…#687

Merged
Alex Sorokoumov (Gerrrr) merged 1 commit into6.1.0-cp5from
10289-6.1.0-cp5
Mar 22, 2022
Merged

KAFKA-10289; Fix failed connect_distributed_test.py (ConnectDistribut…#687
Alex Sorokoumov (Gerrrr) merged 1 commit into6.1.0-cp5from
10289-6.1.0-cp5

Conversation

@Gerrrr
Copy link
Copy Markdown

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…edTest.test_bounce) (apache#9673)

In Python 3, `filter` functions return iterators rather than `list` so it can traverse only once. Hence, the following loop will only see "empty" and then validation fails.

```python
        src_messages = self.source.committed_messages() # return iterator
        sink_messages = self.sink.flushed_messages()) # return iterator
        for task in range(num_tasks):
            # only first task can "see" the result. following tasks see empty result
            src_seqnos = [msg['seqno'] for msg in src_messages if msg['task'] == task]
```

Reference: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter.

Reviewers: Jason Gustafson <[email protected]>
@Gerrrr
Copy link
Copy Markdown
Author

I double-checked that all 5 broken tests in the CI run fail on the base branch as well. This patch should be safe to merge.

@Gerrrr Alex Sorokoumov (Gerrrr) merged commit 766830c into 6.1.0-cp5 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants