KAFKA-10289; Fix failed connect_distributed_test.py (ConnectDistribut…#687
Merged
Alex Sorokoumov (Gerrrr) merged 1 commit into6.1.0-cp5from Mar 22, 2022
Merged
KAFKA-10289; Fix failed connect_distributed_test.py (ConnectDistribut…#687Alex Sorokoumov (Gerrrr) merged 1 commit into6.1.0-cp5from
Alex Sorokoumov (Gerrrr) merged 1 commit into6.1.0-cp5from
Conversation
…edTest.test_bounce) (apache#9673) In Python 3, `filter` functions return iterators rather than `list` so it can traverse only once. Hence, the following loop will only see "empty" and then validation fails. ```python src_messages = self.source.committed_messages() # return iterator sink_messages = self.sink.flushed_messages()) # return iterator for task in range(num_tasks): # only first task can "see" the result. following tasks see empty result src_seqnos = [msg['seqno'] for msg in src_messages if msg['task'] == task] ``` Reference: https://portingguide.readthedocs.io/en/latest/iterators.html#new-behavior-of-map-and-filter. Reviewers: Jason Gustafson <[email protected]>
Sameh (SamehTawfik)
approved these changes
Mar 21, 2022
Author
|
I double-checked that all 5 broken tests in the CI run fail on the base branch as well. This patch should be safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)