add aws-java-sdk-sts to aws extension classpath#95
Merged
Conversation
Naya Chen (CodingParsley)
changed the title
Naya Chen (CodingParsley)
changed the title
Naya Chen (CodingParsley)
changed the title
Naya Chen (CodingParsley)
requested review from
Xavier Léauté (xvrl)
and removed request for
Xavier Léauté (xvrl)
April 18, 2022 23:38
Xavier Léauté (xvrl)
requested changes
Apr 19, 2022
Xavier Léauté (xvrl)
left a comment
Xavier Léauté (xvrl)
left a comment
Member
There was a problem hiding this comment.
one minor request + calling out the other module we need to add the dependency in.
| <artifactId>validation-api</artifactId> | ||
| </dependency> | ||
|
|
||
| <!-- runtime --> |
Member
There was a problem hiding this comment.
let's explain why we need this dependency
Naya Chen (CodingParsley)
force-pushed
the
iam-patch
branch
from
April 19, 2022 18:12
9b44e2e to
2e475f9
Compare
Naya Chen (CodingParsley)
requested a review
from Harini Rajendran (harinirajendran)
April 19, 2022 20:34
Xavier Léauté (xvrl)
requested changes
Apr 19, 2022
Xavier Léauté (xvrl)
left a comment
Xavier Léauté (xvrl)
left a comment
Member
There was a problem hiding this comment.
we still need to add the dependency to the druid-aws-rds-extensions
Author
|
Tested with local image and it's able to connect to RDS successfully. Xavier Léauté (@xvrl) Would appreciate a +1:) |
Naya Chen (CodingParsley)
requested review from
Time E. Less (time-less-ness) and
Xavier Léauté (xvrl)
April 20, 2022 15:54
Member
|
we should mention in the PR description that this also fixes the token auth for RDS |
Xavier Léauté (xvrl)
approved these changes
Apr 21, 2022
Naya Chen (CodingParsley)
added a commit
that referenced
this pull request
Apr 25, 2022
* add sdk to aws common classpath * add runtime scope for sts dependency * add comment
Naya Chen (CodingParsley)
added a commit
that referenced
this pull request
Apr 27, 2022
* add sdk to aws common classpath * add runtime scope for sts dependency * add comment
Naya Chen (CodingParsley)
added a commit
that referenced
this pull request
Apr 27, 2022
* add sdk to aws common classpath * add runtime scope for sts dependency * add comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache#11303
Description
WebIdentityTokenProviderin the defaultAWSCredentialsProviderChain can not actually be used because theaws-java-sdk-stsjar is not in the classpath of S3 extension at runtime, since each extension has its own classpath.The error message from
getCredentials()is:This PR will fix multiple authentication modules that are dependent on the
WebIdentityTokenProvider, including AWS IAM based RDS authentication and S3 authentication.This PR has: