Skip to content

OBSDATA-2905: Attach user identity to router request logs (#15126)#179

Merged
Ratish Ravindran (ratishr) merged 1 commit into
28.0.1-confluentfrom
OBSDATA-2905-enable-user-identity-logs
Jan 4, 2024
Merged

OBSDATA-2905: Attach user identity to router request logs (#15126)#179
Ratish Ravindran (ratishr) merged 1 commit into
28.0.1-confluentfrom
OBSDATA-2905-enable-user-identity-logs

Conversation

@ratishr

Copy link
Copy Markdown
Member
  • Attach user identity to router request logs

  • Add test

  • More tests

(cherry picked from commit 7802078)

Description

Currently, with the Druid version we are using, the user information is missing in the logs when a user queries a data source the via Druid Console e.g.

{"query/time":212,"success":true}	{"query":"SELECT \"__time\", \"logical_cluster_id\", \"value_max\"\nFROM \"telemetry_metrics\"\nWHERE \"name\" = 'cc_control_plane_kafka.requested_ckus' and  \"value_max\" > 0\n\n","context":{"sqlOuterLimit":1001,"sqlQueryId":"41636992-128d-42c0-92a9-6432dd2f58e4","queryId":"41636992-128d-42c0-92a9-6432dd2f58e4"}}

The user information is required as a part of the ongoing Audit Logging Effort.

The OpenSource branch has the change to include user identity in the request logs PR. Cherry-picked the same to include the change.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

* Attach user identity to router request logs

* Add test

* More tests

(cherry picked from commit 7802078)
@cla-assistant

cla-assistant Bot commented Jan 4, 2024

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant

cla-assistant Bot commented Jan 4, 2024

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ratishr
Ratish Ravindran (ratishr) merged commit 7245e1a into 28.0.1-confluent Jan 4, 2024
@ratishr
Ratish Ravindran (ratishr) deleted the OBSDATA-2905-enable-user-identity-logs branch January 4, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants