Remove resolver param passed to validate() in JSON schema #2186
Merged
Robert Yokota (rayokota) merged 1 commit intomasterfrom Feb 6, 2026
Merged
Remove resolver param passed to validate() in JSON schema #2186Robert Yokota (rayokota) merged 1 commit intomasterfrom
Robert Yokota (rayokota) merged 1 commit intomasterfrom
Conversation
Naxin Fang (fangnx)
requested review from
a team and
Matthew Seal (MSeal)
as code owners
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Naxin Fang (fangnx)
changed the title
Robert Yokota (rayokota)
previously approved these changes
Feb 6, 2026
Member
Robert Yokota (rayokota)
left a comment
Robert Yokota (rayokota)
left a comment
There was a problem hiding this comment.
Thanks Naxin Fang (@fangnx) , LGTM
There was a problem hiding this comment.
Pull request overview
Removes passing a resolver into JSON Schema validation to avoid AttributeError caused by jsonschema’s deprecated RefResolver behavior and incompatibility with referencing.Resolver.
Changes:
- Stop passing
resolver=...intovalidate()when validating resolved subschemas.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Robert Yokota (rayokota)
approved these changes
Feb 6, 2026
Robert Yokota (rayokota)
deleted the
fix/inc-8778-json-schema-resolver-bug
branch
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RefResolver is deprecated as of 4.18.0 and we are using 4.24.0 of jsonschema library: https://github.com/python-jsonschema/jsonschema/blob/cbaf0f8fe9be1825477419f2ac02f835cc292198/jsonschema/validators.py#L471
What happens:
AttributeError: 'Resolver' object has no attribute 'resolving'Checklist
References
JIRA: https://confluentinc.atlassian.net/browse/INC-8778
Test & Review
Open questions / Follow-ups