Feature/bugfix 1616#1630
Merged
Emanuele Sabellico (emasab) merged 17 commits intomasterfrom Oct 25, 2023
Merged
Conversation
|
|
Pranav Rathi (pranavrth)
requested changes
Oct 16, 2023
Member
Pranav Rathi (pranavrth)
left a comment
Pranav Rathi (pranavrth)
left a comment
There was a problem hiding this comment.
First round of reviews.
I would suggest to find better ways make "all" case similar to old cases.
Pranav Rathi (pranavrth)
requested changes
Oct 17, 2023
Member
Pranav Rathi (pranavrth)
left a comment
Pranav Rathi (pranavrth)
left a comment
There was a problem hiding this comment.
Add test cases and changelog
mahajanadhitya
force-pushed
the
feature/bugfix-1616
branch
from
08d155c to
ed16fc4
Compare
to describe all the users, keeps previous behavior for a list
Contributor
|
Made some change following what we were talking about, keeping same behavior if a list is passed |
Pranav Rathi (pranavrth)
requested changes
Oct 25, 2023
Member
Pranav Rathi (pranavrth)
left a comment
Pranav Rathi (pranavrth)
left a comment
There was a problem hiding this comment.
- Rebase the branch.
- None and empty list both have same behavior. Reflect this in the docs.
Pranav Rathi (pranavrth)
requested changes
Oct 25, 2023
| # Describe User Scram API | ||
| a = AdminClient({"socket.timeout.ms": 10}) | ||
|
|
||
| f = a.describe_user_scram_credentials() |
There was a problem hiding this comment.
Add an integration test for the fix that we are deploying i.e. describe all users case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1616