Add enableAt to RuleSet#470
Merged
Robert Yokota (rayokota) merged 2 commits intomasterfrom Mar 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces an enableAt field on RuleSet and uses it in the Serde rule-execution path to conditionally disable rule execution based on the configured environment.
Changes:
- Add
enableAt?: stringto theRuleSetinterface. - Plumb
enableAtthroughexecuteRulesWithPhaseintoRuleContext. - Update rule disabling logic to skip rules unless
enableAtis unset/ALL/CLIENT.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
schemaregistry/serde/serde.ts |
Reads RuleSet.enableAt, propagates it via RuleContext, and gates rule execution in isDisabled. |
schemaregistry/schemaregistry-client.ts |
Extends the public RuleSet type to include the new enableAt property. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Justin Wang (Claimundefine)
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add enableAt to RuleSet. Also update CHANGELOG
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups