DGS-23025 Add AssociatedNameStrategy#454
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for AssociatedNameStrategy in the TypeScript schema registry client, which allows subject names to be determined by querying associations stored in the schema registry. The PR also adds support for RecordNameStrategy and TopicRecordNameStrategy, and makes the SubjectNameStrategyFunc type support both synchronous and asynchronous implementations.
Changes:
- Added
AssociatedNameStrategythat queries schema registry associations to determine subject names - Added
RecordNameStrategyandTopicRecordNameStrategyfor schema-based subject naming - Modified
SubjectNameStrategyFuncto support async implementations (returnsstring | Promise<string>) - Added association-related types and API methods to the schema registry client
- Added comprehensive test coverage for the new strategies
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| schemaregistry/serde/serde.ts | Core implementation of AssociatedNameStrategy, RecordNameStrategy, TopicRecordNameStrategy, and related helper functions; modified SubjectNameStrategyFunc signature to support async |
| schemaregistry/serde/avro.ts | Added getRecordName method to AvroSerializer and AvroDeserializer; configured subject name strategy in constructors |
| schemaregistry/serde/json.ts | Added getRecordName method to JsonSerializer and JsonDeserializer; configured subject name strategy in constructors |
| schemaregistry/serde/protobuf.ts | Added getRecordName method to ProtobufSerializer and ProtobufDeserializer; configured subject name strategy in constructors |
| schemaregistry/schemaregistry-client.ts | Added Association-related types, LifecyclePolicy enum, and API methods for managing associations |
| schemaregistry/mock-schemaregistry-client.ts | Implemented association management in mock client; modified getBySubjectAndId to support empty subject lookups |
| schemaregistry/test/serde/avro.spec.ts | Added comprehensive tests for RecordNameStrategy, TopicRecordNameStrategy, and AssociatedNameStrategy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
airlock-confluentinc
Bot
force-pushed
the
assoc-strategy
branch
from
84beda5 to
3db0252
Compare
|
Justin Wang (Claimundefine)
left a comment
Justin Wang (Claimundefine)
left a comment
There was a problem hiding this comment.
LGTM
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups