Conversation
This PR does a cleanup after the assessment PR introduced some unncessary dependencies.
Waiting for open-policy-agent/opa#6754 to be merged. This removes 15-16 dependencies that we dont use 🎉
This was not completly finished in the last one. It is a problem of testify, but they are working on it (see stretchr/testify#1772). This hopefully fixes that
oxisto
changed the title
go.yaml.in/yaml/v3
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on dependency cleanup and consistency updates across the workspace, including switching YAML v3 imports to go.yaml.in/yaml/v3, moving remaining error handling away from gRPC status errors toward Connect errors, and updating dependency versions (including OPA).
Changes:
- Replace
gopkg.in/yaml.v3imports withgo.yaml.in/yaml/v3in core services/tests. - Migrate some error handling from
google.golang.org/grpc/status/codestoconnectrpc.com/connecterrors. - Update and reorder Go module/workspace dependencies (core/go.mod, core/go.sum, go.work.sum).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.work.sum | Updated workspace dependency checksums after dependency cleanup/updates. |
| core/service/orchestrator/metrics.go | Switch YAML v3 import to go.yaml.in/yaml/v3. |
| core/service/assessment/assessment.go | Replace gRPC status errors with Connect errors in handleEvidence and adjust related comments/imports. |
| core/policies/rego.go | Use Connect error codes instead of gRPC status parsing when handling “not found” cases. |
| core/policies/policies_test.go | Switch YAML v3 import to go.yaml.in/yaml/v3 in tests. |
| core/go.mod | Dependency cleanup/reorg; update OPA and add go.yaml.in/yaml/v3. |
| core/go.sum | Updated checksums to match updated core dependencies. |
| confirmate.code-workspace | Extend workspace spell-check word list for project-specific identifiers. |
Codecov Report✅ All modified and coverable lines are covered by tests.
|
immqu
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not completely finished in the last one. It is a problem of testify, but they are working on it (see stretchr/testify#1772).
This hopefully fixes that