Skip to content

zarr v2.9.0 - #48

Merged
joshmoore merged 2 commits into
conda-forge:masterfrom
regro-cf-autotick-bot:2.9.0_h6928f1
Aug 23, 2021
Merged

joshmoore merged 2 commits into
conda-forge:masterfrom
regro-cf-autotick-bot:2.9.0_h6928f1

Conversation

@regro-cf-autotick-bot

Copy link
Copy Markdown
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1157761270, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

  • line_profiler

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@joshmoore
joshmoore merged commit 84a2238 into conda-forge:master Aug 23, 2021
@regro-cf-autotick-bot
regro-cf-autotick-bot deleted the 2.9.0_h6928f1 branch August 23, 2021 09:49
@Anthchirp

Copy link
Copy Markdown
Member

The build didn't actually run on the PR, and neither is it running on master.
So this package will not be built/published.

@Anthchirp

Copy link
Copy Markdown
Member

@joshmoore

joshmoore commented Aug 23, 2021 •

Copy link
Copy Markdown
Member

@Anthchirp : thanks, and apologies for the noise. In my rush to get this through, I failed to notice the failure.

My plan would be to roll out a 2.9.1 Zarr which properly skips the tests in zarr-developers/zarr-python#817. A few questions:

  • Is jumping over 2.9.0 on conda forge going to cause issues?
  • Would adding fsspec as a dependency be an option (for everyone)?
  • Additionally, will builds get created for RCs for testing this type of issue?

@jakirkham

Copy link
Copy Markdown
Member

Nope shouldn't cause any issues. Would go ahead with that plan.

I don't have strong feelings on that, but maybe add an issue on the Zarr repo and see what people say. FWIW we can add it as a test only dependency just to make sure things are working.

RCs are not handled automatically in conda-forge. We would need to do that manually.

@joshmoore

Copy link
Copy Markdown
Member

Thanks, @jakirkham. Moving forward with zarr-developers/zarr-python#819 and I'll capture in an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants