Skip to content

[MRG] Version 0.19.2#67

Merged
jakirkham merged 6 commits intoconda-forge:masterfrom
rth:v0.19.2
Jul 16, 2018
Merged

[MRG] Version 0.19.2#67
jakirkham merged 6 commits intoconda-forge:masterfrom
rth:v0.19.2

Conversation

@rth
Copy link
Copy Markdown
Member

@rth rth commented Jul 14, 2018 •
edited
Loading

This tests the upcoming 0.19.2 release can be built without errors. Do not merge.

Packages the 0.19.2 release

@conda-forge-linter
Copy link
Copy Markdown

conda-forge-linter commented Jul 14, 2018

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@rth rth mentioned this pull request Jul 14, 2018
Merged
@conda-forge-linter
Copy link
Copy Markdown

conda-forge-linter commented Jul 15, 2018

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@rth rth changed the title [NOMRG] Test latest changes in 0.19.X [MRG] Version 0.19.2 Jul 15, 2018
@conda-forge-linter
Copy link
Copy Markdown

conda-forge-linter commented Jul 15, 2018

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@rth
Copy link
Copy Markdown
Member Author

rth commented Jul 15, 2018

@conda-forge-admin, please rerender

@rth rth mentioned this pull request Jul 15, 2018
Closed
@ogrisel
Copy link
Copy Markdown
Contributor

ogrisel commented Jul 15, 2018

There is a failure:

https://travis-ci.org/conda-forge/scikit-learn-feedstock/jobs/404161032

Traceback (most recent call last):
  File "/Users/travis/miniconda3/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/cli/main_build.py", line 420, in main
    execute(sys.argv[1:])
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/cli/main_build.py", line 411, in execute
    verify=args.verify)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/api.py", line 200, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/build.py", line 2177, in build_tree
    notest=notest,
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/build.py", line 1571, in build
    built_package = bundlers[output_d.get('type', 'conda')](output_d, m, env, stats)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/build.py", line 938, in bundle_conda
    files = post_process_files(metadata, initial_files)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/build.py", line 800, in post_process_files
    post_build(m, new_files, build_python=python)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/post.py", line 649, in post_build
    post_process_shared_lib(m, f, prefix_files)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/post.py", line 599, in post_process_shared_lib
    mk_relative_osx(path, m.config.host_prefix, m.config.build_prefix, files=files)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/post.py", line 346, in mk_relative_osx
    names = macho.otool(path)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/os_utils/macho.py", line 167, in otool
    raise CalledProcessError
TypeError: __init__() missing 2 required positional arguments: 'returncode' and 'cmd'

@rth
Copy link
Copy Markdown
Member Author

rth commented Jul 15, 2018

Yes, it's due to #66 (comment) maybe I shouldn't have re-rended.

Will remove the last commit and see if it helps..

jakirkham
jakirkham reviewed Jul 15, 2018
View reviewed changes
recipe/meta.yaml Outdated

build:
number: 201
number: 0
Copy link
Copy Markdown
Member

@jakirkham jakirkham Jul 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this needs to be 200.

ref: https://conda-forge.org/docs/blas.html

Copy link
Copy Markdown
Member

@jakirkham jakirkham Jul 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also use this trick ( conda-forge/numpy-feedstock@4a98d05 ).

Copy link
Copy Markdown
Member Author

@rth rth Jul 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Set it to 200, I think it's still more explicit that setting then incrementing the build_number variable..

@jakirkham jakirkham merged commit 912103f into conda-forge:master Jul 16, 2018
@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Jul 16, 2018

Thanks @rth and @ogrisel :)

@rth rth deleted the v0.19.2 branch July 16, 2018 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rth @conda-forge-linter @ogrisel @jakirkham @conda-forge-admin