Skip to content

mlflow v1.28.0#100

Merged
xhochy merged 8 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:1.28.0_h763057
Aug 19, 2022
Merged

mlflow v1.28.0#100
xhochy merged 8 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:1.28.0_h763057

Conversation

@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
mlflow 1.28.0 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • python-kubernetes
  • pyspark
  • urllib3
  • xgboost
  • pylint
  • tabulate
  • astroid
  • pytorch-lightning
  • arm_pyart
  • tensorflow
  • py4j

Packages found in the meta.yaml but not found by source code inspection:

  • waitress
  • gunicorn

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2840071871, please use this URL for debugging.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'mlflow-ui-dbg' output doesn't have any tests.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [60]

For recipe:

  • It looks like the 'mlflow-ui-dbg' output doesn't have any tests.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Aug 15, 2022

@conda-forge-admin please rerender

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'mlflow-ui-dbg' output doesn't have any tests.

@github-actions
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/mlflow-feedstock/actions/runs/2859239095.

Comment thread recipe/meta.yaml
Comment on lines -64 to -74
# MLflow Pipelines dependencies
- scikit-learn >=1.0.* # [mlflow_variant != "skinny"]
- pyarrow >=7.0.* # [mlflow_variant != "skinny"]
- shap >=0.40.* # [mlflow_variant != "skinny"]
# pandas-profiling version is not restricted to prevent the following jobs from failing:
# - linux linux_ppc64le_mlflow_variantdefaultpython3.10.____cpython
# - linux linux_ppc64le_mlflow_variantdefaultpython3.9.____cpython
- pandas-profiling # [mlflow_variant != "skinny"]
- ipython >=7.0.* # [mlflow_variant != "skinny"]
- markdown >=3.3.* # [mlflow_variant != "skinny"]
- Jinja2 >=3.0.* # [mlflow_variant != "skinny"]
Copy link
Copy Markdown
Contributor

@harupy harupy Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy Thanks for the update! Can we keep the dependencies for MLflow Pipelines?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harupy I would rather keep them as a separate package/outpt mlflow-pipelines (this is how we deal with extras in all other packages). I can do this as part of this PR.

Copy link
Copy Markdown
Contributor

@harupy harupy Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy To confirm, to install mlflow-pipelines, users need to
run the following command, right?

conda install mlflow-pipelines

Copy link
Copy Markdown
Contributor

@harupy harupy Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a discussion on this today. Let's create mlflow-pipelines.

@harupy
Copy link
Copy Markdown
Contributor

harupy commented Aug 15, 2022

It looks like the environment variable http_proxy and https_proxy are defined in the windows jobs and the assertions added in https://github.com/mlflow/mlflow/pull/6120/files failed:

Traceback (most recent call last):
  File "D:\bld\mlflow-split_1660550110647\test_tmp\run_test.py", line 29, in <module>
    import mlflow.sagemaker
  File "D:\bld\mlflow-split_1660550110647\_test_env\lib\site-packages\mlflow\sagemaker\__init__.py", line 24, in <module>
    from mlflow.models.container import SUPPORTED_FLAVORS as SUPPORTED_DEPLOYMENT_FLAVORS
  File "D:\bld\mlflow-split_1660550110647\_test_env\lib\site-packages\mlflow\models\container\__init__.py", line 23, in <module>
    from mlflow.models.docker_utils import DISABLE_ENV_CREATION
  File "D:\bld\mlflow-split_1660550110647\_test_env\lib\site-packages\mlflow\models\docker_utils.py", line 46, in <module>
    assert parsed_http_proxy.hostname is not None, "Invalid `http_proxy` hostname."
AssertionError: Invalid `http_proxy` hostname.

@harupy
Copy link
Copy Markdown
Contributor

harupy commented Aug 16, 2022

@xhochy Any clue on why the error above occurs?

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Aug 17, 2022

Both variables are set to empty:

2022-08-17T08:30:29.2632683Z HTTPS_PROXY=
2022-08-17T08:30:29.2632985Z HTTP_PROXY=

@harupy
Copy link
Copy Markdown
Contributor

harupy commented Aug 17, 2022

@xhochy Thanks for the investigation! Is it possible to remove them or set dummy values? If it's not, can we ignore the failed windows jobs in this release?

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'mlflow-ui-dbg' output doesn't have any tests.
  • It looks like the 'mlflow-pipelines' output doesn't have any tests.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Aug 18, 2022

@harupy Can you have a final look here?

Copy link
Copy Markdown
Contributor

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @xhochy!

@xhochy xhochy merged commit 447d351 into conda-forge:main Aug 19, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 1.28.0_h763057 branch August 19, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants