Skip to content

update conda to 25.3.1#807

Merged
hmaarrfk merged 2 commits intoconda-forge:mainfrom
millsks:main
Jul 29, 2025
Merged

update conda to 25.3.1#807
hmaarrfk merged 2 commits intoconda-forge:mainfrom
millsks:main

Conversation

@millsks
Copy link
Copy Markdown
Contributor

@millsks millsks commented Jul 29, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #806

@millsks millsks requested a review from a team as a code owner July 29, 2025 20:39
@millsks
Copy link
Copy Markdown
Contributor Author

millsks commented Jul 29, 2025

@conda-forge-admin, please rerender

@millsks
Copy link
Copy Markdown
Contributor Author

millsks commented Jul 29, 2025

@conda-forge/miniforge ready for review.

@hmaarrfk hmaarrfk merged commit fef9a0c into conda-forge:main Jul 29, 2025
8 checks passed
Comment thread Miniforge3/construct.yaml
Comment on lines +31 to +32
- conda =={{ version.split("-")[0] }}
- mamba =={{ mamba_version }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @millsks, can you remember why this change was needed? The main point of user_requested_specs is that it ends up in the History file, which is used by conda to see what the user wanted at install time. If we ==-pin here, then conda is less likely to offer updates. We chose >= intentionally when we set this up 🤔

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #838 for the revert.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @millsks, can you remember why this change was needed? The main point of user_requested_specs is that it ends up in the History file, which is used by conda to see what the user wanted at install time. If we ==-pin here, then conda is less likely to offer updates. We chose >= intentionally when we set this up 🤔

Hi @jaimergp . IIRC it was to make sure that whenever we installed Miniforge it had the same versions each time. We had approval for 25.3.1 for example, but not for the next subsequent versions.

The first few times we were ok, but as soon as the next versions of conda and the other packages came out it would use those newer versions and it technically wasn't the approved 25.3.1 installer anymore because of version drift.

If this needs to get reverted we can just modify it in our construct file again. We were trying to avoid too many changes to what the open source version was releasing.

For example when we build the installer we change out the conda-forge channel with our channels on our internal Artifactory and adding a few additional packages we needed internally, but we were keeping the versions of the packages that were originally there the same.

jaimergp added a commit to jaimergp/miniforge that referenced this pull request Dec 5, 2025
@jaimergp jaimergp mentioned this pull request Dec 5, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

conda 25.3.0 does not display environment name on cmd (Miniforge Prompt) (Windows only)

3 participants