Conversation
|
The artifacts are available and include the PKG installers. This PR is not done (see description), but those should be functional already. Please let me know if you have any feedback! |
|
Looks great! |
|
Check these ones: https://github.com/conda-forge/miniforge/actions/runs/7915666236 I don't think they require superuser per se, but maybe there's a bug. Let me know. |
|
Yea I found the right artifacts, tried the mini forge-arm64 and it did require admin. |
|
So first, it doesn't wanna open because it's not signed and apple hates us.
I went into security settings and allowed it explicitly (required admin), so the dialog box got less scary: It allowed me to install it just on my home directory Failed the first time because I already have it installed But it works now, after! So I suppose it needs to be signed? Thanks for working on this, @jaimergp! |
|
Yes, the signing machinery is there in constructor (thanks napari!), we just need the Apple certificate from NumFocus. |
|
Also, if you have feedback about the messaging, we can customize some steps. |
|
Only suggestion is to maybe have something in there about pre-existing installations? But that's very minor, as the target audience for this probably does not have pre-existing installations. |
I think this is a fair first approximation. However, I think we get many questions on this issue tracker where people have trouble installing miniforge when Miniconda or Anaconda is already installed (and to a lesser extent when miniforge or mambaforge is already installed). |
| - __osx >=10.13 # [osx] | ||
|
|
||
| # macOS PKG options | ||
| installer_type: all # [osx] |
There was a problem hiding this comment.
Make this an option using an environment variable.
|
Ok, for anyone interested in trying these out, the PKGs at https://github.com/conda-forge/miniforge/actions/runs/21754318045?pr=434 are now signed and notarized, which means that macOS won't bug you when you try to open them. |
|
Love this! |
|
The shell script is just the other installer option (better for CLI and unattended runs like CI), nothing to do with PKG. It's just there because the GHA artifact glob picked both.
There's an optional screen you can go to to "customize the install" and in there there are some optional "components", which is the way we offer some options via PKG. |
|
@conda-forge/miniforge, this is ready for review now 🙏 |
|
I don’t have a Mac so I’m unable to review the user interactions. |
|
Hey @hmaarrfk, I'd be willing to schedule a videocall or something where I can share my screen and let you review it, if that's something you want to do. Otherwise we can also let someone else in the team take a look. |
|
Im leaning toward maybe a screen recording and you updating the top level comment. If this is "an other option" I'm happy to try it as well and see what users think without much direct review from me. |
|
Got it this looks cool and great. The checklist adds a few customizations that I don't know if they made it or not in your final version. Just looking for confirmation if the latest checklist is correct. Now I'm thinking. How can we make this for Linux...... I hate the shell only option. |
|
I didn't customize much, just the "background" which is the anvil logo you see on the bottom left corner. Everything else is the "default". I think it's a good way to get started, though. |
I'm not aware of any standard graphical installer for Linux (or at least, not a generic cross-distro one), and constructor doesn't support anything else anyway, so for now we don't have any options there. |
hmaarrfk
left a comment
There was a problem hiding this comment.
Let’s leave this open until march 1
|
final question. Can you confirm that the artifacts will be uploaded on tags? |
|
I think the glob in this line covers the new .pkg files too: miniforge/.github/workflows/ci.yml Line 156 in 8a8ff42 |
|
Awesome |
|
did something break the builds? |




Closes #429
Tasklist
Welcome screenshot: