Release 25.08 +SP +SIMD#54
Merged
conda-forge-admin merged 12 commits intoconda-forge:mainfrom Aug 14, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ax3l
force-pushed
the
release-25.08-sp-simd
branch
from
4a0b428 to
08bea00
Compare
Member
Author
|
@conda-forge-admin, please rerender |
This comment was marked as outdated.
This comment was marked as outdated.
…nda-forge-pinning 2025.08.13.14.30.17
This was referenced Aug 13, 2025
Known to fail
ax3l
force-pushed
the
release-25.08-sp-simd
branch
from
cb21ce4 to
b1d9341
Compare
5 tasks
Member
Author
|
Will need this AMReX patch for macOS/Windows SIMD support:
And this ImpactX patch: |
WeiqunZhang
pushed a commit
to AMReX-Codes/amrex
that referenced
this pull request
Aug 13, 2025
## Summary Ensure we can use any producing type's `simd_mask`, e.g., `double`, when setting (in)valid particles, by manipulating our `uint64` in `idcpu`. This currently requires a conversion/cast in C++. Make this conversion portable, so far it only worked on GCC/Linux. This helper needs C++20. Thus, build AMReX conditionally always with C++20 or newer when SIMD is requested (non-default). Eventually, we will require C++26 once this becomes standard, and C++29 will have even more updates. ## Additional background Portability to macOS/Windows: - conda-forge/impactx-feedstock#54 - mattkretz/vir-simd#45 ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
ax3l
force-pushed
the
release-25.08-sp-simd
branch
from
4c73116 to
4ffecf0
Compare
Known to fail
ax3l
force-pushed
the
release-25.08-sp-simd
branch
from
4092080 to
76a6a1f
Compare
ax3l
force-pushed
the
release-25.08-sp-simd
branch
3 times, most recently
from
597e34b to
32f09c7
Compare
ax3l
force-pushed
the
release-25.08-sp-simd
branch
from
32f09c7 to
ca31784
Compare
Member
Author
|
Huh, that tolerance should be big enough now o.0 Hm, |
Contributor
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release ImpactX 25.08.
ImpactX_SIMD(disabled for Multipole on windows)conda install -c conda-forge "impactx>=25.08[build=*sp_*]"Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)