Skip to content

feat: support Windows#77

Merged
github-actions[bot] merged 7 commits intoconda-forge:masterfrom
coryan:feat-windows-support
Dec 8, 2021
Merged

feat: support Windows#77
github-actions[bot] merged 7 commits intoconda-forge:masterfrom
coryan:feat-windows-support

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Dec 7, 2021 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • N/A Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #76

@conda-forge-linter
Copy link

conda-forge-linter commented Dec 7, 2021

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@coryan coryan marked this pull request as ready for review December 7, 2021 18:00
@coryan
Copy link
Contributor Author

coryan commented Dec 7, 2021

@conda-forge-admin, please rerender

xhochy
xhochy reviewed Dec 7, 2021
View reviewed changes
@xhochy
Copy link
Member

xhochy commented Dec 8, 2021

@conda-forge-admin please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@xhochy
Copy link
Member

xhochy commented Dec 8, 2021

@coryan feel free to add yourself as a maintainer here to also be able to merge things :)

@coryan
Copy link
Contributor Author

coryan commented Dec 8, 2021

Good idea, sending #79. I assume that will change the GitHub permissions?

@xhochy xhochy mentioned this pull request Dec 8, 2021
Closed
5 tasks
@xhochy
Copy link
Member

xhochy commented Dec 8, 2021

Good idea, sending #79. I assume that will change the GitHub permissions?

Yes!

@conda-forge-admin please rerender

@xhochy xhochy added the automerge Merge the PR when CI passes label Dec 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2021 •
edited
Loading

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@github-actions github-actions bot merged commit 70c09a3 into conda-forge:master Dec 8, 2021
@coryan coryan deleted the feat-windows-support branch December 9, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhochy xhochy xhochy left review comments

@davidbrochart davidbrochart Awaiting requested review from davidbrochart

Assignees

No one assigned

Labels

automerge Merge the PR when CI passes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create binary packages for Windows

3 participants

@coryan @conda-forge-linter @xhochy