fix: google-cloud-cpp ignores CMAKE_CXX_STANDARD#69
fix: google-cloud-cpp ignores CMAKE_CXX_STANDARD#69xhochy merged 2 commits intoconda-forge:masterfrom coryan:fix-cmake-cxx-version-override
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipe/build.sh
Outdated
| echo CMAKE_ARGS=${CMAKE_ARGS} | ||
|
|
||
| cmake ${CMAKE_ARGS} \ | ||
| -GNinja \ | ||
| -DCMAKE_PREFIX_PATH=$PREFIX \ | ||
| -S google/cloud/storage/quickstart -B build_cmake_test | ||
| cmake --build build_cmake_test |
There was a problem hiding this comment.
Can you put this into the test section? (see https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#test-section)
There was a problem hiding this comment.
Done (I think). Though I am not sure how useful this PR is now that the recipe is using v1.33.0.
There was a problem hiding this comment.
It's good to have this as a check for regressions.
|
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
3 participants
Fixes #68