Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
|
@conda-forge-admin, please rerender |
|
@conda-forge-admin, please rerender |
|
Needs windows build of netcdf-fortran, see conda-forge/netcdf-fortran-feedstock#3, conda-forge/netcdf-fortran-feedstock#52, conda-forge/netcdf-fortran-feedstock#60. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
5558a4b to
5953008
Compare
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.01.25.09.30.06
|
@conda-forge-admin, please restart ci |
|
@conda-forge-admin, please restart ci |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.01.26.09.23.31
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.02.04.12.26.59
|
@zklaus as @xylar already said, this is amazing! What an herculean effort! I'd love if @rokuingh could look at the patches and, if possible, upstream them. However, I'm OK merging this as-is b/c if you are the main user of this package you'll know pretty soon if it is OK or not. PS: I'm stealing the honor of merging this now but I'll definitely buy you and @xylar a 🍺 and/or ☕ if we manage to meet in person. |
|
Cheers, guys! Very happy to see this come along. Re upstreaming, I have the patches in a branch against upstream at https://github.com/zklaus/esmf/tree/develop-windows. The commits should be largely orthogonal, i.e. easy to cherry-pick. I'll try to do PRs myself, but won't be mad at all if someone else gets to it first ;) Re meeting in person, that's a great idea! You wouldn't happen to be in Vienna in late April? |
Awesome! I can try to send them if you are too busy.
I no longer have an excuse to go to Vienna (EGU) b/c I'm not doing science anymore but I hope to be back. I'll keep you posted if I land there. If you are coming to SciPy in the USA please let me know. |
Checklist
Reset the build number to0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Add a windows build (closes #64)