Skip to content

Pin message-pack to <1.0 (recently release and incompatible) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakirkham merged 1 commit into from
Feb 19, 2020
Merged

Pin message-pack to <1.0 (recently release and incompatible) #114

jakirkham merged 1 commit into from
Feb 19, 2020

Conversation

@Carreau
Copy link
Contributor

@Carreau Carreau commented Feb 19, 2020 •
edited by jakirkham
Loading

As per dask/distributed#3494, dask/distributed#3498 and dask/distributed#3491

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [ ] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

conda-forge-linter commented Feb 19, 2020

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Carreau Carreau mentioned this pull request Feb 19, 2020
Merged
@jakirkham
Copy link
Member

jakirkham commented Feb 19, 2020

@conda-forge-admin, please re-render.

@conda-forge-linter
Copy link

conda-forge-linter commented Feb 19, 2020

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@jakirkham jakirkham merged commit 19b2449 into conda-forge:master Feb 19, 2020
@jakirkham
Copy link
Member

jakirkham commented Feb 19, 2020

Thanks @Carreau! 😄

If we wind up needing to mark packages as broken, we can now do so by submitting the package names here.

@jjhelmus
Copy link
Contributor

jjhelmus commented Feb 19, 2020

Alternatively the existing packages can be hotfixed to include a maximum message-pack pinning.

If the older packages are moved to broken please ping me so I can adjust the packages in defaults accordingly.

@jrbourbeau jrbourbeau mentioned this pull request Feb 26, 2020
Closed
@jjhelmus
Copy link
Contributor

jjhelmus commented Feb 26, 2020

A hotfix for older versions of distributed is being worked on in conda-forge/conda-forge-repodata-patches-feedstock#32

@Carreau
Copy link
Contributor Author

Carreau commented Feb 27, 2020

Thanks, I was unsure I understood how to hotfix.

I dropped a question in the PR you link, in particular I'm not quite sure I understand how this gen-patch-json will only apply the hotfix to already released packages.

@jakirkham jakirkham mentioned this pull request Mar 23, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham Awaiting requested review from jakirkham

@jcrist jcrist Awaiting requested review from jcrist

@jrbourbeau jrbourbeau Awaiting requested review from jrbourbeau

@marcelotrevisani marcelotrevisani Awaiting requested review from marcelotrevisani

@martindurant martindurant Awaiting requested review from martindurant

@mrocklin mrocklin Awaiting requested review from mrocklin

@ogrisel ogrisel Awaiting requested review from ogrisel

@TomAugspurger TomAugspurger Awaiting requested review from TomAugspurger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Carreau @conda-forge-linter @jakirkham @jjhelmus